Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop sample from EF Core-Blazor article #34482

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Jan 13, 2025

Fixes #34478

I'll drop the sample from the Blazor Samples repo on dotnet/blazor-samples#441 after this merges.


Internal previews

📄 File 🔗 Preview link
aspnetcore/blazor/blazor-ef-core.md aspnetcore/blazor/blazor-ef-core
aspnetcore/blazor/fundamentals/index.md aspnetcore/blazor/fundamentals/index

@guardrex
Copy link
Collaborator Author

guardrex commented Jan 13, 2025

@adegeo (cc: @Rick-Anderson) ... We don't normally apply subsvc labels to PRs. Is this something new? If not, then there's a mini-😈 in the new label management process/code.

@adegeo
Copy link
Contributor

adegeo commented Jan 13, 2025

It's not required. We do it in .NET docs to identify what area a PR touches. You want me to remove that?

@guardrex
Copy link
Collaborator Author

@Rick-Anderson ... Do you concur that we don't want the subsvc labels on the PRs, or is that useful to the team? Personally, I don't need them for anything.

@Rick-Anderson
Copy link
Contributor

@Rick-Anderson ... Do you concur that we don't want the subsvc labels on the PRs, or is that useful to the team? Personally, I don't need them for anything.

I vote to nix them. We've got too many labels now.

@guardrex
Copy link
Collaborator Author

Ok, thx @Rick-Anderson.

@adegeo ... We only need the subsvc labels on issues.

@guardrex guardrex mentioned this pull request Jan 15, 2025
67 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Factor the sample out of the EF Core-Blazor article
3 participants