allow query options to appear in any order any number of times #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zachmu
reviewed
Oct 18, 2023
go/vt/sqlparser/ast.go
Outdated
| Comments Comments | ||
| Distinct string | ||
| Hints string | ||
| QueryOpts []string |
There was a problem hiding this comment.
We don't need each option as a separate field in the Select struct, but a string slice is too free form. You probably want to have a QueryOpts struct to hold these things during list construction with a .Merge() method like we have with column type options
added 2 commits
October 18, 2023 13:56
zachmu
approved these changes
Oct 18, 2023
| StraightJoinHint = "straight_join " | ||
| DistinctStr = "distinct " | ||
| AllStr = "all " | ||
| StraightJoinHintStr = "straight_join " |
There was a problem hiding this comment.
They're used in the Format() method, and some other parts of sql.y still rely on DistinctStr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow statements like this to parse:
Fixes dolthub/dolt#6829
Companion PR: dolthub/go-mysql-server#2088