Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for a partials directory #9

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

barlock
Copy link

@barlock barlock commented Oct 23, 2014

This also has the benefit of making the live reload plugin work with handlebars partials

@barlock
Copy link
Author

barlock commented Oct 23, 2014

fix #6

@balupton
Copy link
Member

@RobLoach want to handle this? needs latest base files

@RobLoach
Copy link
Contributor

@balupton Doesn't DocPad provide its own partial-esque mechanism? Or am I thinking of something else?

@balupton
Copy link
Member

@RobLoach yeah we do, however handlebars has it's own thing. I'm not too fussed about the contents of this issue, just the failing tests.

@barlock
Copy link
Author

barlock commented Nov 11, 2014

@RobLoach Which files need updating? Just merge the latest files from bevy/base into the the plugin?

@balupton
Copy link
Member

@mbarlock @RobLoach

whoever gets to it first, change required is:

wget -N https://raw.githubusercontent.com/bevry/base/master/.gitignore
wget -N https://raw.githubusercontent.com/bevry/base/master/.npmignore
wget -N https://raw.githubusercontent.com/bevry/base/master/.travis.yml
wget -N https://raw.githubusercontent.com/bevry/base/master/.editorconfig
wget -N https://raw.githubusercontent.com/bevry/base/master/Cakefile
wget -N https://raw.githubusercontent.com/bevry/base/master/LICENSE.md
wget -N https://raw.githubusercontent.com/bevry/base/master/CONTRIBUTING.md
wget -N https://raw.githubusercontent.com/bevry/base/master/coffeelint.json
wget -N https://raw.githubusercontent.com/bevry/base/master/.jshintrc
cake prepublish
git add .gitignore .npmignore .travis.yml .editorconfig Cakefile LICENSE.md CONTRIBUTING.md coffeelint.json .jshintrc
git add -u

@barlock
Copy link
Author

barlock commented Nov 12, 2014

Got it!

@balupton
Copy link
Member

balupton commented Aug 1, 2019

I have become too preoccupied by other things to review, merge, and release this PR.

However, you should have received an invite a while ago to join the DocPad Extras Team, which will give you write access to this repository, so you can merge in the PR, and become one of the maintainers of this repository.

For an orientation, or if you need any assistance following the semi-automatic release process from CONTRIBUTING.md, reach out via https://bevry.me/discord/dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants