Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for instances casting spell with no spell flags #3824

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

walt253
Copy link
Contributor

@walt253 walt253 commented Jan 12, 2025

This PR fix this issue:

Creatures do not use instances with SELF_BUFF when configured with different ValidateSourceFunc & ValidateTargetFunc if the spell lacks spell flags.

    // Return false for instances affecting the caster when no spell flags are set.
    if (spell_flags == 0)
    {
        return false;
    }
@walt253 walt253 marked this pull request as ready for review January 12, 2025 05:05
@Loobinex Loobinex merged commit 5abfb5f into master Jan 14, 2025
1 check passed
@Loobinex Loobinex deleted the NoSpellFlagsCastFix branch January 14, 2025 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants