Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint only changed files in the PR #2908

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Lint only changed files in the PR #2908

merged 1 commit into from
Dec 4, 2024

Conversation

shubham1g5
Copy link
Contributor

Summary

Run lint check only on the changed files to reduce the noise.

PR Checklist

  • If I think the PR is high risk, "High Risk" label is set
  • I have confidence that this PR will not introduce a regression for the reasons below
  • Do we need to enhance manual QA test coverage ? If yes, "QA Note" label is set correctly
  • Does the PR introduce any major changes worth communicating ? If yes, "Release Note" label is set and a "Release Note" is specified in PR description.

Automated test coverage

NA

Safety story

Tooling change

@shubham1g5 shubham1g5 added the skip-integration-tests Skip android tests. label Dec 4, 2024
@shubham1g5 shubham1g5 force-pushed the lintOnlyChangedFiles branch 3 times, most recently from 1c47669 to 6be8588 Compare December 4, 2024 11:54
@shubham1g5 shubham1g5 force-pushed the lintOnlyChangedFiles branch from 6be8588 to bca1a8c Compare December 4, 2024 11:54
@shubham1g5 shubham1g5 marked this pull request as ready for review December 4, 2024 12:30
@shubham1g5
Copy link
Contributor Author

@damagatchi retest this please

@shubham1g5 shubham1g5 merged commit d4d32c8 into master Dec 4, 2024
6 checks passed
@shubham1g5 shubham1g5 deleted the lintOnlyChangedFiles branch December 4, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pm-dimagi pm-dimagi pm-dimagi approved these changes

@avazirna avazirna Awaiting requested review from avazirna

@OrangeAndGreen OrangeAndGreen Awaiting requested review from OrangeAndGreen

Assignees
No one assigned
Labels
skip-integration-tests Skip android tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shubham1g5 @pm-dimagi