Fix barcode screen glitch

[avazirna]

Summary

This PR fixes an issue with the Case List screen in which a search bar is shown momentarily when the case list is being rendered (see image below).

Context

In versions prior to Android 3.0, the top bar was merely a title bar, it was only capable of holding text so search and navigation related actions (and others) had to be delegated to custom toolbars. CommCare has one such toolbar in case lists, searchfooter, to allow users to filter cases:

Older version of the Case list

With support to Android 3.0 and earlier versions ending in CommCare 2.44.0, this toolbar became obsolete. So, this PR removes all the code associated with this feature and, as a consequence, it fixes the issue described above.

Safety Assurance

• I have confidence that this PR will not introduce a regression for the reasons below
• Do we need to enhance manual QA test coverage ? If yes, "QA Note" label is set correctly
• Does the PR introduce any major changes worth communicating ? If yes, "Release Note" label is set and a "Release Note" is specified in PR description.

Safety story

This PR removes obsolete code and it is not expected to cause any regressions. I have had the opportunity to test this on both the minimum and highest versions of Android currently supported by CommCare and there were no issues.

[ctsims]

@avazirna I think the code looks good here, but a few points on the PR:

1- This PR is really two meaningful changes (or one change for two big reasons). One is eliminating legacy code that no longer has an execution path, the other is fixing a bug that happens to get fixed when that code is removed.

I'd make sure that both of those intents are communicated here. If someone git blames back to this PR, it would be super confusing for them to see that the reason that 80 lines of code and a bunch of views were removed was to fix a bug where a view temporarily flickered and disappeared.

2 - You have the safety story checked but don't provide an explanation on why it's safe. I think that context does exist from our chats (IE: It's clear looking at Shubham's PR that there used to be a meaningful conditional where a bunch of code wasn't activated, and now there isn't), so it's good to include that background info here so a reviewer can see that this code couldn't possibly be used. Also good to confirm that you've tested the new view layouts on the two screens correctly and confirmed that they behave right still after eliminating the view (and needing to re-anchor on a new view)

[avazirna]

@avazirna I think the code looks good here, but a few points on the PR:

1- This PR is really two meaningful changes (or one change for two big reasons). One is eliminating legacy code that no longer has an execution path, the other is fixing a bug that happens to get fixed when that code is removed.

I'd make sure that both of those intents are communicated here. If someone git blames back to this PR, it would be super confusing for them to see that the reason that 80 lines of code and a bunch of views were removed was to fix a bug where a view temporarily flickered and disappeared.

2 - You have the safety story checked but don't provide an explanation on why it's safe. I think that context does exist from our chats (IE: It's clear looking at Shubham's PR that there used to be a meaningful conditional where a bunch of code wasn't activated, and now there isn't), so it's good to include that background info here so a reviewer can see that this code couldn't possibly be used. Also good to confirm that you've tested the new view layouts on the two screens correctly and confirmed that they behave right still after eliminating the view (and needing to re-anchor on a new view)

@ctsims thanks for the notes, I will update the PR to make sure this removal is well documented. As per the testing, it seems to be working as expected in newer versions of Android, but I still need to test on older versions.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request involves removing search-related UI components from multiple files in an Android application. In the XML layout file entity_select_layout.xml, a LinearLayout containing search elements such as a label, input field, and barcode scanning button has been deleted. Correspondingly, in the CommCareActivity and FormRecordListActivity Java files, related code for managing these search components has been removed. The changes suggest a significant modification to the search functionality, potentially replacing the existing search mechanism with an alternative approach. The layout structure has been adjusted to remove the search footer, and the associated Java code no longer initializes or manipulates the previously existing search-related UI elements.

Sequence Diagram

sequenceDiagram
    participant UI as User Interface
    participant Activity as FormRecordListActivity
    participant SearchView as SearchView Component

    UI->>Activity: User opens activity
    Activity->>SearchView: Initialize search mechanism
    Note over Activity, SearchView: Previous search footer and EditText removed
    SearchView-->>Activity: Ready for search input

Loading

This sequence diagram illustrates the simplified search flow after removing the previous search components, showing a more streamlined approach to search functionality within the activity.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0a85740 and ceed5f3.

📒 Files selected for processing (3)

• app/res/layout/entity_select_layout.xml (1 hunks)
• app/src/org/commcare/activities/CommCareActivity.java (0 hunks)
• app/src/org/commcare/activities/FormRecordListActivity.java (0 hunks)

💤 Files with no reviewable changes (2)

• app/src/org/commcare/activities/CommCareActivity.java
• app/src/org/commcare/activities/FormRecordListActivity.java

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Lint Code Base

🔇 Additional comments (3)

app/res/layout/entity_select_layout.xml (3)

71-71: LGTM! Layout reference updated correctly.

The layout reference has been updated from the removed searchfooter to universal_frame_tile, maintaining the correct vertical layout flow.

---

Line range hint 1-116: Verify layout behavior on different Android versions.

As mentioned in the PR comments by ctsims, please ensure that the new layout structure works correctly on both newer and older Android versions after removing the search footer.

Let's check for any version-specific layout attributes or potential conflicts:

✅ Verification successful

Layout changes are version-agnostic and follow Android best practices

The layout uses standard Android framework components and attributes that are well-supported across all Android versions. The search footer removal was implemented cleanly without introducing any version-specific dependencies or conflicts.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for Android version-specific layout attributes
echo "Searching for version-specific layout attributes..."
rg "android:layout_.*=\"@.*\"" app/res/layout/entity_select_layout.xml

# Search for any layout-related issues in the issue tracker
echo "Searching for related layout issues..."
gh issue list --search "in:title layout android version"

Length of output: 689

---

Line range hint 10-39: Consider removing unused search result components.

The search_result_banner and its child components (search_results_status, clear_search_button) appear to be related to the removed search functionality. Consider removing these components if they are no longer needed.

Let's verify if these components are still referenced in the codebase:

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[avazirna]

@damagatchi retest this please

[avazirna]

@damagatchi retest this please