feat: 질문 폼 생성하기 베이스 배경 이미지 적용 #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyesungoh
requested review from
oyeon-kwon,
sjoleee and
sumi-0011
as code owners
Bundle SizesCompared against 57ce4fa
Dynamic import: No significant changes found |
sumi-0011
reviewed
Mar 20, 2024
| @@ -19,6 +20,10 @@ const SurveyBasePage: NextPage = () => { | |||
| <Link href="/survey/create" css={linkCss}> | |||
| <Button color="blue">폼 생성하기</Button> | |||
| </Link> | |||
|
|
|||
| <div css={backgroundImageWrapperCss}> | |||
| <Image quality={100} src="/images/survey/base.webp" alt="배경" fill objectFit="cover" /> | |||
There was a problem hiding this comment.
webp를 지원하지 않는 브라우저라면 처리 해주지 않아도 되는걸까요?
There was a problem hiding this comment.
There was a problem hiding this comment.
이제 주 사용처가 웹뷰가 될 거 같기도 했구요 !!
* feat: 설문이 있을 때 핸들링 * feat: 연구 결과 피드백 없을 때 마크업 (#492) * chore: 결과 베이스 이미지 * feat: mobile header props 뚫기 * feat: 결과 베이스
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 해결하려는 문제가 무엇인가요?
제곧내
🌄 스크린샷