feat: 하단 바 추가 #484
Merged
feat: 하단 바 추가 #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyeon-kwon
requested review from
hyesungoh,
sjoleee and
sumi-0011
as code owners
Bundle SizesCompared against 2702658
Dynamic import: No significant changes found |
hyesungoh
reviewed
Mar 14, 2024
There was a problem hiding this comment.
아이콘들의 props를 다른 컴포넌트 처럼
ComponentProps<typeof Svg> 요롷게 해주시면 확장해서 쓰기 편할 거 같은데 어떻게 생각하세용?!?!
Comment on lines
20
to
30
| const onHomeClick = () => { | ||
| router.push('/gallery'); | ||
| }; | ||
|
|
||
| const onQuestionClick = () => { | ||
| router.push('/survey/create'); | ||
| }; | ||
|
|
||
| const onMyCardClick = () => { | ||
| router.push(`/dna/${data?.survey_id}`); | ||
| }; |
There was a problem hiding this comment.
태그가 아닌 button의 onClick으로 링킹을 하신 이유가 궁금해요 !!
sumi-0011
requested changes
Mar 14, 2024
Comment on lines
24
to
26
| const onQuestionClick = () => { | ||
| router.push('/survey/create'); | ||
| }; |
There was a problem hiding this comment.
설문지를 이미 만든 사용자는 내 연구결과 -> /result 페이지로 이동되어야할 것 같습니다!
Comment on lines
20
to
22
| const onHomeClick = () => { | ||
| router.push('/gallery'); | ||
| }; |
There was a problem hiding this comment.
이후에 /gallery 경로의 페이지가 없어지고
갤러리 화면이 / 경로로 변경될 예정이여서, / 경로로 바꿔주세요!
There was a problem hiding this comment.
이거 루트가 갤러리가 되는 이유는 뭐지 ??? @sumi-0011
시간 간단히 잡아서 싱크업해도 좋을듯??
Comment on lines
92
to
98
| const { isLoading, data } = useGetSurveyIdByUserStatus({ | ||
| onError: () => { | ||
| fireToast({ content: '문제가 발생했어요. 다시 시도해 주세요.' }); | ||
| router.push('/'); | ||
| }, | ||
| }); | ||
|
|
There was a problem hiding this comment.
statue가 로그인 상태일 때만 쿼리가 실행되도록 해도 좋지않을까요?
enabled 옵션으로요!
| return ( | ||
| <footer css={BottomBarCss(theme)}> | ||
| <button type="button" css={IconBoxCss(theme, '/gallery' === currentPath)} onClick={onHomeClick}> | ||
| <HomeIcon color={'/gallery' === currentPath ? `${theme.colors.primary_300}` : `${theme.colors.gray_300}`} /> |
There was a problem hiding this comment.
여기도 /gallery가 아닌 /으로 변경 부탁드려요!
저도 /gallery 페이지를 빠르게 제거해볼게요!
* feat: �질문 폼 베이스 * refactor: bottom bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 해결하려는 문제가 무엇인가요?
🎉 변경 사항
🙏 여기는 꼭 봐주세요!
🌄 스크린샷