Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: yarn version upgrade #483

Merged
merged 9 commits into from
Mar 18, 2024
Merged

refactor: yarn version upgrade #483

merged 9 commits into from
Mar 18, 2024

Conversation

hyesungoh
Copy link
Member

@hyesungoh hyesungoh commented Mar 11, 2024

๐Ÿค” ํ•ด๊ฒฐํ•˜๋ ค๋Š” ๋ฌธ์ œ๊ฐ€ ๋ฌด์—‡์ธ๊ฐ€์š”?

  • node 20 ๋ฒ„์ „ ๋Œ€์—์„œ ๊ฐœ๋ฐœ ์„œ๋ฒ„ ์‹คํ–‰์ด ์•ˆ๋จ

๐ŸŽ‰ ๋ณ€๊ฒฝ ์‚ฌํ•ญ

  • ์ตœ์‹  ๋ฒ„์ „์˜ yarn์œผ๋กœ ์˜ฌ๋ฆฌ๊ธฐ

  • ci ํ„ฐ์ง€๋Š” ๋ฌธ์ œ ํ•ด๊ฒฐ

    • ํŒจํ‚ค์ง€๋“ค ๋งˆ์ด๋„ˆ ๋ฒ„์ „์— ํ•œํ•ด์„œ ์ „๋ถ€ ์—…๊ทธ๋ ˆ์ด๋“œ
    • ํƒ€์ž… ์ถ”๋ก  ์•ˆ๋˜๋Š” ๋ถ€๋ถ„ ๋ฐ˜์˜
    • ๋ฆฐํŠธ, ์Šคํƒ€์ผ๋ฆฐํŠธ fix
    • ํฌ๋กœ๋งˆํŒ… ํ„ฐ๋ณด์Šค๋ƒ… ๋น„ํ™œ์„ฑํ™”
    • ์ค‘๋ณต ์„ค์น˜๋œ ์˜์กด์„ฑ ์‚ญ์ œ๋ฅผ ์œ„ํ•ด lock ์‚ญ์ œ ๋ฐ ์žฌ์„ค์น˜

@hyesungoh hyesungoh self-assigned this Mar 11, 2024
@github-actions github-actions bot added workflow Change for workflow ci Change for CI labels Mar 11, 2024
@sumi-0011
Copy link
Member

ci build ํ„ฐ์ง€๋Š”๋ฐ ๊ดœ์ฐฎ์€๊ฑธ๊นŒ์š”? @hyesungoh

@hyesungoh
Copy link
Member Author

ci build ํ„ฐ์ง€๋Š”๋ฐ ๊ดœ์ฐฎ์€๊ฑธ๊นŒ์š”? @hyesungoh

์•„ ์ด๊ฑฐ WIP...

@hyesungoh hyesungoh marked this pull request as draft March 14, 2024 07:51
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 89.38%. Comparing base (62d13ee) to head (69f8b6f).
Report is 23 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #483   +/-   ##
=======================================
  Coverage   89.38%   89.38%           
=======================================
  Files          44       44           
  Lines         339      339           
  Branches       62       62           
=======================================
  Hits          303      303           
  Misses         36       36           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

Copy link

Bundle Sizes

Compared against 2702658

Route Size (gzipped) Diff
/_app 238.5 KB +8.84 KB
/gallery 107.35 KB added
/gallery/bookmarks 82.8 KB added
/survey/base 83.6 KB added
/survey/create 108.44 KB +4.78 KB

Dynamic import: No significant changes found

@hyesungoh hyesungoh marked this pull request as ready for review March 18, 2024 13:28
@hyesungoh hyesungoh merged commit d8b4459 into main Mar 18, 2024
13 checks passed
@hyesungoh hyesungoh deleted the refactor/yarn-version-up branch March 18, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Change for CI workflow Change for workflow
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants