Make tests/overflow_large consistently return PASS/FAIL with and without quiet #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's something off about the logic of tests/overflow_large.c. It was returning FAIL if TESTS_QUIET was set, and PASS if not. This patch moves all the test_pass()/test_fail() calls outside of if (quiet).
I also added a variable "silent", currently set to equal "quiet". As I was testing it, I wanted a variation that told me the specific error was without adding all the status information that of ! quiet.
I think it's a good thing, but this is optional and separate from the logic fix.