Fix generic test not null and unique custom configs #11208
Conversation
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11208 +/- ##
==========================================
- Coverage 88.93% 88.87% -0.06%
==========================================
Files 187 187
Lines 24104 24041 -63
==========================================
- Hits 21436 21367 -69
- Misses 2668 2674 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -104,7 +104,7 @@ def test_env_vars_models(self, project): | |||
| schema_file = manifest.files[source.file_id] | |||
| test_id = "test.test.source_not_null_seed_sources_raw_customers_id.e39ee7bf0d" | |||
| test_node = manifest.nodes[test_id] | |||
| assert test_node.config.severity == "WARN" | |||
| assert test_node.config.severity == "warn" | |||
There was a problem hiding this comment.
Will these casing changes show up in output artifacts? If so what do you think the impact could be?
There was a problem hiding this comment.
The only generic tests which had the severity changed from "warn" to "WARN" were the specially-handled not_null and unique tests. All of the other generic tests did not do the uppercasing. So I don't think the impact would be much.
Resolves #
Problem
When the ability to have custom configs in generic tests was added, it missed the special code for handling not_null and unique tests.
Solution
Access "config" from the test builder instead of "get_static_config"
Checklist