Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create LogNodeResult event #11195

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Create LogNodeResult event #11195

merged 2 commits into from
Jan 8, 2025

Conversation

aranke
Copy link
Member

@aranke aranke commented Jan 7, 2025

Problem

We need a new event to log generic node result events with dynamic messages.

Solution

Create a new LogNodeResult event

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Jan 7, 2025
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.87%. Comparing base (7106005) to head (3c4e191).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11195      +/-   ##
==========================================
- Coverage   88.93%   88.87%   -0.06%     
==========================================
  Files         187      187              
  Lines       24057    24099      +42     
==========================================
+ Hits        21395    21419      +24     
- Misses       2662     2680      +18     
Flag Coverage Δ
integration 86.18% <60.00%> (-0.13%) ⬇️
unit 62.41% <100.00%> (+0.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.41% <100.00%> (+0.35%) ⬆️
Integration Tests 86.18% <60.00%> (-0.13%) ⬇️

@aranke aranke marked this pull request as ready for review January 7, 2025 21:20
@aranke aranke requested a review from a team as a code owner January 7, 2025 21:20
@aranke aranke requested a review from MichelleArk January 7, 2025 21:20
@aranke aranke changed the title Create LogNodeResult event Create LogNodeResult event Jan 7, 2025
Copy link
Contributor

@gshank gshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems odd that we'd load up the event with a dictionary of status_to_message_map, when at the time we do that, we'd in theory already have the status. Is there some reason to do it this way instead of simply loading the appropriate message?

@aranke aranke requested a review from gshank January 8, 2025 13:55
@aranke
Copy link
Member Author

aranke commented Jan 8, 2025

@gshank Good catch, looks like I can simplify further which I have done.
Could you please re-review this PR? Thanks!

@aranke aranke merged commit dcc9a0c into main Jan 8, 2025
54 of 56 checks passed
@aranke aranke deleted the log_node_result branch January 8, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants