Skip to content
This repository has been archived by the owner on Sep 8, 2024. It is now read-only.

Fix colors "works on my machine" #98

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

nokola
Copy link
Contributor

@nokola nokola commented Mar 25, 2024

Quick fix to get colors working on Windows - please use as you wish! Ok to close/abandon.

Issue it fixes:

var<private> black_color: vec4<f32> = vec4<f32>(0.15f, 0.15f, 0.21f, 1f);

Expected: Render above shader color as almost black
Actual: renders as light gray

Wrong color example:

image

Fixed color example:

image

Also fixed:
image

@nokola
Copy link
Contributor Author

nokola commented Mar 25, 2024

For info - I don't know if it will break semi-transparent texture color, haven't tested. Might be OK?

The gist of the change is that render texture/shaders are now considered linear as they are rather than sRGB

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant