This repository has been archived by the owner on Sep 8, 2024. It is now read-only.
Use BTreeMap for deterministic MeshKey iteration to prevent z-fighting #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setzer22
force-pushed
the
make_mesh_queue_use_btreemap
branch
from
6e117b0 to
4dda34e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The render queues are currently stored in a
HashMapthat is discarded and re-created each frame.This is problematic, because each time the hashmap is created, it randomizes iteration order. And then, when two overlapping sprites are rendered with the same z-index, you get z-fighting.
I think the easiest way to solve this is to simply swap the
HashMaps withBTreeMap, but feel free to implement something else if you have a better idea 👍