Chore: use a single package for all Feature structs #3278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also replaces `golang.org/x/exp/slices` with `slices` from the Go 1.21 stdlib > small spin-off from dapr#3046 Signed-off-by: ItalyPaleAle <[email protected]>
|
Where is the tracking issue for this? Why are we doing this? I would like some explanation - no PRs without discussion. |
Just a refactoring to avoid code duplication. Instead of having a |
berndverst
approved these changes
Jan 8, 2024
eunicecompra
pushed a commit
to eunicecompra/components-contrib
that referenced
this pull request
Jan 9, 2024
Signed-off-by: ItalyPaleAle <[email protected]> Co-authored-by: Bernd Verst <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also replaces
golang.org/x/exp/sliceswithslicesfrom the Go 1.21 stdlib