Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump for node 18.17.0 to support latest next.js 14 release #989

Closed
wants to merge 2 commits into from

Conversation

JackHowa
Copy link

@JackHowa JackHowa commented Oct 31, 2023

@CLAassistant
Copy link

CLAassistant commented Oct 31, 2023

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link

@JackHowa JackHowa changed the title feat: Generate a new image for node 18.17.0, chrome 118.0.5993.117-1 feat: Generate a new image for node 18.17.0 Oct 31, 2023
@JackHowa JackHowa changed the title feat: Generate a new image for node 18.17.0 chore: Generate a new image for node 18.17.0 Oct 31, 2023
@JackHowa JackHowa changed the title chore: Generate a new image for node 18.17.0 chore: Bump for node 18.17.0 to support latest next.js release Oct 31, 2023
@JackHowa JackHowa changed the title chore: Bump for node 18.17.0 to support latest next.js release chore: Bump for node 18.17.0 to support latest next.js 14 release Oct 31, 2023
@JackHowa
Copy link
Author

Really appreciate the effort keeping these up to date. This is ready for review but can't seem to trigger that per the docs. cc @chrisbreiding @astone123

@MikeMcC399
Copy link
Collaborator

@MikeMcC399
Copy link
Collaborator

MikeMcC399 commented Nov 1, 2023

@JackHowa

Is Next.js 14 compatible with the existing

cypress/browsers:node-20.9.0-chrome-118.0.5993.88-1-ff-118.0.2-edge-118.0.2088.46-1

if Next.js 14 specifies "Node.js 18.17 or later" in the Next.js Installation instructions?

@JackHowa
Copy link
Author

JackHowa commented Nov 1, 2023

@JackHowa

Is Next.js 14 compatible with the existing

cypress/browsers:node-20.9.0-chrome-118.0.5993.88-1-ff-118.0.2-edge-118.0.2088.46-1

if Next.js 14 specifies "Node.js 18.17 or later" in the Next.js Installation instructions?

I assume so! I haven't tried. But we want to mimic what's running with greater than or equal to 18.17 and less than 19 in our testing environment @MikeMcC399

@MikeMcC399
Copy link
Collaborator

@JackHowa

I don't speak for the Cypress team here as I'm a community contributor only, so I can't say in advance what their response to your PR will be.

Just in case you are not aware and in case it might meet any urgent need, you can generate your own Cypress Docker image using the Cypress Docker factory with a choice of your own version parameters.

@emilyrohrbough
Copy link
Member

@JackHowa Thank you for providing details in the PR description to describe your needs for this image. Like @MikeMcC399 mention, we offer the Cypress Docker factory to allow you to build custom images that can be more specific to your test needs. Wanting a specific Node version than what we offer is a great use-case for leveraging the Factory image. You can use this example as a base-line for defining your own with just Chrome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants