Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (console) : Throw error for crc console configured with MicroShift preset (#4561) #4576

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rohanKanojia
Copy link
Contributor

Description

Fixes: #4561

Relates to: crc-org/docs#16

Instead of printing wrong information simply throw an error to indicate to the user that crc console option is unsupported for MicroShift preset

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Proposed changes

Instead of printing wrong information like this:

To login as a regular user, run 'oc login -u developer -p developer '.
To login as an admin, run 'oc login -u kubeadmin -p  '

Thrown error message saying console option is not supported for MicroShift preset:

error : this option is not supported for microshift preset. Please refer to the documentation for a list of supported presets for using this option

Testing

  1. crc config set preset microshift
  2. crc setup
  3. crc start
  4. crc console should throw error

Contribution Checklist

  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Which platform have you tested the code changes on?
    • Linux
    • Windows
    • MacOS

…ift preset (crc-org#4561)

Instead of printing wrong information simply throw an error to indicate to the user
that `crc console` option is unsupported for MicroShift preset

Signed-off-by: Rohan Kumar <[email protected]>
Copy link

openshift-ci bot commented Jan 17, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Jan 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign praveenkumar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] crc console gives incorrect output on microshift preset
1 participant