gitignore: Fix cross-platform compatibility for sed in-place editing #4540
Conversation
|
@praveenkumar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
- On macOS, `sed -i extension` requires a space between `-i` and the extension to perform in-place changes without creating a backup file. - On Linux, `sed -i[extension]` or `--in-place[extension]` does not require a space, which makes it difficult to write a single command that works on both platforms. As a result, the JSON backup file generated on macOS with the `-e` extension is ignored.
praveenkumar
force-pushed
the
issue_4539
branch
from
6df3751 to
fd7de9c
Compare
praveenkumar
changed the title
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rohanKanojia The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sed -i extensionrequires a space between-iand the extensionto perform in-place changes without creating a backup file.
sed -i[extension]or--in-place[extension]does not require a space,which makes it difficult to write a single command that works on both platforms.
As a result, the JSON backup file generated on macOS with the
-eextension is ignored.To test this change run
make gen_release_infoon all platform