Improve checks #136
Merged
Improve checks #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuelm41
approved these changes
Jan 15, 2025
| @@ -93,6 +129,10 @@ parser_error_t check_swap_conditions(parser_context_t *ctx_parsed_tx) { | |||
| char tmpKey[20] = {0}; | |||
| char tmpValue[65] = {0}; | |||
|
|
|||
| if ((app_mode_expert() && ctx_parsed_tx->tx_obj->tx_json.num_items > 10) || (!app_mode_expert() && ctx_parsed_tx->tx_obj->tx_json.num_items > 6)) { | |||
There was a problem hiding this comment.
Can we convert these numbers into defines?
There was a problem hiding this comment.
What if we have less? shouldn't it be equal signs?
Comment on lines
-216
to
-220
|
|
||
| #ifdef HAVE_SWAP | ||
| // Finalize the transaction with failure status | ||
| finalize_exchange_sign_transaction(false); | ||
| #endif |
There was a problem hiding this comment.
Isn't it needed anymore?
There was a problem hiding this comment.
I have added this in the last PR, but by mistake I was not running all the tests.
This time I noticed this line is closing the communication between the exchange and app-cosmos. But it leaves the app-exchange hanging, not returning the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.