Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add 08-wasm code owners #5100

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Conversation

crodriguezvega
Copy link
Contributor

Description

closes: #XXXX

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@github-actions github-actions bot added docs Improvements or additions to documentation core 06-solomachine 07-tendermint testing Testing package and unit/integration tests dependencies Issues or PRs to update a dependency 03-connection 08-wasm github_actions Pull requests that update Github_actions code 02-client e2e protobuf Proto file definitions and protobuf code generation gRPC Issues for gRPC endpoints CLI labels Nov 13, 2023
@crodriguezvega crodriguezvega changed the base branch from main to feat/wasm-clients November 13, 2023 15:50
@crodriguezvega crodriguezvega removed docs Improvements or additions to documentation core 06-solomachine 07-tendermint dependencies Issues or PRs to update a dependency labels Nov 13, 2023
@crodriguezvega crodriguezvega removed 03-connection 08-wasm github_actions Pull requests that update Github_actions code 02-client e2e gRPC Issues for gRPC endpoints CLI testing Testing package and unit/integration tests protobuf Proto file definitions and protobuf code generation labels Nov 13, 2023
Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! :)

.github/CODEOWNERS Show resolved Hide resolved
@github-actions github-actions bot added the github_actions Pull requests that update Github_actions code label Nov 14, 2023
@crodriguezvega crodriguezvega merged commit 825bf2b into feat/wasm-clients Nov 14, 2023
12 of 14 checks passed
@crodriguezvega crodriguezvega deleted the carlos/08-wasm-code-owners branch November 14, 2023 14:39
@crodriguezvega crodriguezvega mentioned this pull request Dec 1, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants