-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdk for testnet-ibc #4917
Closed
Closed
sdk for testnet-ibc #4917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s#3486) Co-authored-by: Jack Zampolin <[email protected]> Co-authored-by: antstalepresh <[email protected]> Co-authored-by: Vladislav Markushin <[email protected]> Co-authored-by: Blas Rodriguez Irizar <[email protected]> Co-authored-by: Jacob Gadikian <[email protected]> Co-authored-by: vuong <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]>
* new error * changed all the errors * feat: Changed some more erros from sdkerrors to errorsmod * added ibcerrors * fixes and linting --------- Co-authored-by: Carlos Rodriguez <[email protected]>
* imp: add separate go.mod for 08-wasm * fix e2e build * remove import * lint * Amend CI testing to not build on arm, correctly cross compile on arm64. (cosmos#4065) * Use alpine for building simd in docker. Link statically. (cosmos#4066) --------- Co-authored-by: Charly <[email protected]> Co-authored-by: Jim Fasarakis-Hilliard <[email protected]>
* remove code ID key from genesis type * address review comment
* bump wasmvm to v1.2.4 * go mod tidy e2e * Update Dockerfile * update libwasm sha * more go mod tidy --------- Co-authored-by: Jim Fasarakis-Hilliard <[email protected]>
* build and test wasm-client on pull request * add arm64 for wasm build only
* merge functions * address review comment
* pin code to the wasm VM cache * follow ibc-go error wrapping standards * Update modules/light-clients/08-wasm/keeper/keeper.go Co-authored-by: Reece Williams <[email protected]> --------- Co-authored-by: Damian Nolan <[email protected]>
* renaming to align with x/wasm naming * fix typo * Update docs/architecture/adr-027-ibc-wasm.md Co-authored-by: Damian Nolan <[email protected]> * address review comments * review comment --------- Co-authored-by: Damian Nolan <[email protected]>
* disallow submessage execution * fix error code * alignment * fix
# Conflicts: # Dockerfile # testing/chain.go
Co-authored-by: Jim Fasarakis-Hilliard <[email protected]>
…#4957) * Remove panic handling testing code for non-panicking methods. * Review changes.
* feat: added initial implementation of getClientID * test: added basic test cases * imp: improved tests and getClientID * feat: added clientID as contractAddr to env * fix: handled updateProposalWrappedStore * imp: added test case for updateProposalWrappedStore * imp: fixed linter complaint * imp: Error -> ErrorIs * style: improved one of the error messages * move error up * style: imp error message * imp: review item * imp: review items * test: added additional tests --------- Co-authored-by: Carlos Rodriguez <[email protected]>
…ting' into testnet-ibc
…for-08-wasm' into testnet-ibc
…into testnet-ibc
@faddat Do we still need this PR? Nothing from the PR is meant to be merged, right? |
@crodriguezvega -- correct, I'm going to close it now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reference PR, not really for merging. We need to make a testnet, since it is really hard to work against the existing testnets.
CONTAINS:
GOALS: