[FIX] display error in case of no available shares

display an error message instead of failing when trying to create a subscription request from a partner and no share products are available.
coopiteasy · Nov 29, 2023 · 6633e88 · 6633e88
1 parent fd98a75
commit 6633e88
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/cooperator/readme/newsfragments/86.bugfix.17.rst b/cooperator/readme/newsfragments/86.bugfix.17.rst
@@ -0,0 +1,2 @@
+Display an error message instead of failing when trying to create a
+subscription request from a partner and no share products are available.
diff --git a/cooperator/wizard/partner_create_subscription.py b/cooperator/wizard/partner_create_subscription.py
@@ -29,8 +29,12 @@ def _default_product_id(self):
                 domain.append(("by_company", "=", True))
             else:
                 domain.append(("by_individual", "=", True))
-
-        return self.env["product.product"].search(domain)[0]
+        products = self.env["product.product"].search(domain)
+        if not products:
+            raise UserError(
+                _("No default share product found for this type of partner.")
+            )
+        return products[0]
 
     def _get_representative(self):
         partner = self._get_partner()
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		Display an error message instead of failing when trying to create a
		subscription request from a partner and no share products are available.