fix: 🐛 handle multiple space rendering when using preserveWhitespace [] #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using preserveWhitespace, is inserted as a string instead of JSX character entity. It is hence not rendered as a whitespace. To fix this, we replace whitespace with nbsp's unicode equivalent Closes: contentful#514
|
@YvesRijckaert Would appreciate if you can help review this MR, thanks in advance 💯 |
YvesRijckaert
changed the title
YvesRijckaert
approved these changes
Feb 15, 2024
|
Hi @YvesRijckaert, I have updated the MR with the latest commits in master. Looks like the workflow process has been updated, can help check if the gh actions issue has been fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using preserveWhitespace,
is inserted as a string instead of JSX character entity. It is hence not rendered as a whitespace. To fix this, we replace whitespace with nbsp's unicode equivalent\u00A0Closes: #514