chore: upgrade to TS version 5.3.2 [] #1600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
app:entry-app-collapsible
app:markdown-app
app:multiple-references-app
app:rich-text-app
app:singleline-app
package:_shared
package:_test
package:boolean
package:checkbox
package:date
package:default-field-editors
package:dropdown
package:json
package:list
package:location
package:markdown
package:multiple-line
package:number
package:radio
package:rating
package:reference
package:rich-text
package:single-line
package:slug
package:tags
package:url
package:validation-errors
labels
aodhagan-cf
reviewed
Feb 2, 2024
| @@ -2,7 +2,6 @@ | |||
| "extends": "../../tsconfig.json", | |||
| "include": ["src", "types"], | |||
| "compilerOptions": { | |||
| "module": "esnext", | |||
There was a problem hiding this comment.
wondering what was the motivation behind removing this?
There was a problem hiding this comment.
It's defined already in the top-level tsconfig and we just repeat it again and again. As we're already extending the shared tsconfig, I would not repeat similar configurations
There was a problem hiding this comment.
Fair enough I only ask because in the packages it's esnext and at the top level it's es2020. Just wanted to make sure this is a conscious change
There was a problem hiding this comment.
The module config is actually exnext on the top level :)
Line 5 in 5bbca86
andipaetzold
approved these changes
Feb 2, 2024
aodhagan-cf
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MayaGillilan updated the TS version already on the top level recently. I'm updating it now for all packages inside the repo.