fix: fixing custom app rich text dnd [TOL-1742] #1599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aodhagan-cf
commented
Feb 1, 2024
| @@ -48,7 +49,10 @@ export function createDragAndDropPlugin(): PlatePlugin { | |||
| if (!dropDisallowed) { | |||
| // Move the drop event to a new undo batch mitigating the bug where undo not only moves it back, | |||
| // but also undoes a previous action: https://github.com/ianstormtaylor/slate/issues/4694 | |||
| editor.history.undos.push([]); | |||
| (editor as unknown as HistoryEditor).history.undos.push({ | |||
There was a problem hiding this comment.
slate-history behind the scenes got refactored to use batch objects with operations instead of an array of arrays
chrishelgert
reviewed
Feb 2, 2024
| @@ -67,7 +67,7 @@ | |||
| "is-plain-obj": "^3.0.0", | |||
| "react-popper": "^2.3.0", | |||
| "slate": "0.94.1", | |||
| "slate-history": "0.66.0", | |||
| "slate-history": "0.100.0", | |||
chrishelgert
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error being throw when dragging and dropping with custom rich text editor.
Todo
EDIT
Because we push a new undo as an empty array this condition doesn't short-circuit and the operations doesn't exist on the empty array. I'm not sure why this is only a problem for the App SDK and hasn't been happening the regular web app Rich Text 🤔
https://github.com/ianstormtaylor/slate/blob/cd93871ae69721f7361e17e8b28feab004a9c855/packages/slate-history/src/with-history.ts#L72C5-L74C73