Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerfile changes to build gvforwarder #460

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Dockerfile changes to build gvforwarder #460

wants to merge 1 commit into from

Conversation

vyasgun
Copy link
Member

@vyasgun vyasgun commented Jan 16, 2025

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vyasgun
Once this PR has been reviewed and has the lgtm label, please assign cfergeau for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vyasgun vyasgun force-pushed the pr/gvforwarder-build branch from e78f584 to 18fa67b Compare January 16, 2025 09:08
cfergeau
cfergeau reviewed Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@cfergeau cfergeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also need to be built and pushed to quay, and to make sure bundles still work with this.

images/Dockerfile
WORKDIR $APP_ROOT/src
COPY . .
RUN make
FROM registry.access.redhat.com/ubi9/go-toolset:1.22.9 AS build
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have expected that changing this line FROM registry.access.redhat.com/ubi9/go-toolset:1.22.9 AS build is enough to fix make image?
I'd use latest rather than a hardcoded version so that we don't need to update it too often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfergeau cfergeau cfergeau left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyasgun @cfergeau