Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix docs about allowed filepaths #108

Merged
merged 4 commits into from
Oct 28, 2024
Merged

Conversation

jameslamb
Copy link
Contributor

Description

Proposes fixing what appears to be a typo in the documentation. The README refers to paths like pkgs32 as "now allowed", but those paths appear to actually NOT be allowed in conda packages:

"""Check the tar archive for unallowed directories."""
unallowed_directories = {"conda-meta", "conda-bld", "pkgs", "pkgs32", "envs"}

Thanks for your time and consideration.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Dec 28, 2023
@jameslamb
Copy link
Contributor Author

I've updated this to latest main again.

@jezdez could I please get a review here? Sorry for the @, but I thought it was appropriate given that this repo doesn't auto-assign reviewers, the change is small / non-controversial (I hope), and it's been about 10 months since this was first opened.

@kenodegard kenodegard merged commit fff3fde into conda:main Oct 28, 2024
2 checks passed
@jameslamb
Copy link
Contributor Author

🎉 thanks very much!

@jameslamb jameslamb deleted the docs/readme branch October 28, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants