Create the output directory if its missing and force is used, otherwise raise
#295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We require contributors to sign our Contributor License Agreement and we don't have one on file for @KrishanBhasin. In order for us to review and merge your code, please e-sign the Contributor License Agreement PDF. We then need to manually verify your signature, merge the PR (conda/infrastructure#847), and ping the bot to refresh the PR. |
KrishanBhasin
force-pushed
the
check-target-dir-early
branch
from
33dc024 to
8490ce5
Compare
KrishanBhasin
commented
Nov 10, 2023
|
This is looking good and would happily merge 👍 Waiting for the CLA to be merged first though. |
|
@conda-bot check |
conda-bot
added
the
cla-signed
|
@xhochy I have tidied it up a little bit and updated the docs/news; this is ready to review now No rush or pressure, just let me know if there's any changes you'd prefer to see |
xhochy
approved these changes
Nov 18, 2023
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've had a couple of occasions where I've used
conda-packand asked it to output to a directory that doesn't exist by accident. The packing goes ahead and the operation eventually fails in theshutil.move()command right at the end.I wanted to make it fail early instead or, if
forcewas used, to create the directory.I've gotten it into a 'good enough' working state, and can tidy it up further if you would be open to merging this change.
Checklist - did you ...
newsdirectory (using the template) for the next release's release notes?