Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to use maxsplit=1 #17571

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

maitrey
Copy link
Contributor

@maitrey maitrey commented Jan 14, 2025

Changelog: Fix: Fix Git is_dirty detection of excluded files with paths
Docs: Omit

I have a file that has a space in its name. In the conan export method I use it like this:

def export(self):
        git = Git(self, self.recipe_folder, excluded=["src/file Component Toolchain.prj"])
        git.coordinates_to_conandata()

and this fails because of the split:

lines = [line.split()[1] for line in lines if line]

Closes #17570

@CLAassistant
Copy link

CLAassistant commented Jan 14, 2025

CLA assistant check
All committers have signed the CLA.

@AbrilRBS AbrilRBS self-assigned this Jan 14, 2025
@AbrilRBS AbrilRBS added this to the 2.12.0 milestone Jan 14, 2025
@maitrey maitrey force-pushed the feature/fixspaceinfilename branch from c7100bb to 48517c7 Compare January 14, 2025 13:54
@AbrilRBS AbrilRBS merged commit 8ea8174 into conan-io:develop2 Jan 14, 2025
33 checks passed
@maitrey maitrey deleted the feature/fixspaceinfilename branch January 14, 2025 15:32
memsharded pushed a commit to memsharded/conan that referenced this pull request Jan 15, 2025
* Updated to use maxsplit=1

* Add tests, unquote paths with spaces

---------

Co-authored-by: Abril Rincón Blanco <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[question] Files with space in name fails when creating an object of Git with excluded list
4 participants