Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nearby: Fix race condition and lag when loading pin details, faster overlay management #6047

Merged
merged 20 commits into from
Dec 20, 2024

Conversation

savsch
Copy link
Contributor

@savsch savsch commented Dec 19, 2024

Description (required)

Fixes #6037, fixes #6040, fixes #6049

Makes some progress on #6038

Changes made

  • Migrated NearbyParentFragmentPresenter to kotlin
  • Streamlined how pin marker overlays are managed in nearby, reducing unnecessary computations
  • Fixed asynchronous loading of pin details, and removed accompanying lag

Tests performed (required)

Tested BetaDebug on Medium Phone (AVD) and a physical device with API levels 34 and 33 respectively.

@savsch savsch marked this pull request as draft December 19, 2024 19:53
@nicolas-raoul
Copy link
Member

Pins indeed loads much faster, and the cached pins are shown without unneeded delay.
Huge improvement, thanks a lot!

@savsch savsch changed the title [DRAFT] Nearby: Fix race condition and lag when loading pin details, faster overlay management Nearby: Fix race condition and lag when loading pin details, faster overlay management Dec 20, 2024
@savsch savsch marked this pull request as ready for review December 20, 2024 10:57
@misaochan misaochan merged commit c891c2b into commons-app:main Dec 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants