-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide voice input if service not available #5904
base: main
Are you sure you want to change the base?
Hide voice input if service not available #5904
Conversation
3bf48a8
to
b6641e7
Compare
Testing now, it is working fine on my device that has voice input. |
You can also disable the speech service :) Record_2024-10-28-08-05-19.mp4 |
Nice tip! I actually tried with my Galaxy 10, on Android 9, and somehow it shows the microphone despite having no voice recognition capabilities as far as I know: PXL_20241028_072059556.mp4Any idea what could be the issue? |
* Flag to check if speech recognition is available. | ||
*/ | ||
val isVoiceRecognitionAvailable by lazy { | ||
SpeechRecognizer.isRecognitionAvailable(this) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're depending on this call to check if service is available or not. Since, I don't have access to the device, do you mind adding a print statement and see if it returns true, then likely issue is with API.
Also try logging in the apps-android-commons/app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailAdapter.java Line 164 in b6641e7
For me when I disable service I get this exception message.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind rebasing? Thanks!
Also, could everyone test with their phones and report the results? Thanks! :-)
Sure |
Signed-off-by: parneet-guraya <[email protected]>
b6641e7
to
471716e
Compare
Yes, could you see if it works for you (try to use any physical device you have especially if older) @neeldoshii @savsch @sonalyadav1 Thanks!! |
Sure |
Fixes #5698
What changes did you make and why?
Tests performed (required)
Tested {
betaDebug
prodDebug
} on Oneplus 9RT, Android 14Steps to test:
Apps
speech