Issue 117 - Update facebook javascript #121
Conversation
rodfersou
force-pushed
the
issue_117
branch
2 times, most recently
from
9512357 to
48d531a
Compare
| var js, fjs = d.getElementsByTagName(s)[0]; | ||
| if (d.getElementById(id)) return; | ||
| js = d.createElement(s); js.id = id; | ||
| js.src = "//connect.facebook.net/{0}/sdk.js#xfbml=1&version=v2.10"; |
There was a problem hiding this comment.
This example from Facebook API is broken, it miss the &version part and then asks for the version at first run (I think it is related with locale change this error)
There was a problem hiding this comment.
check the code produced by the widget, not the one in the example.
| @@ -16,5 +16,5 @@ | |||
| </tal:image> | |||
| <meta tal:condition="view/admins" property="fb:admins" tal:attributes="content view/admins" /> | |||
| <meta tal:condition="view/app_id" property="fb:app_id" tal:attributes="content view/app_id" /> | |||
| <script type="application/javascript" tal:content="view/fbjs"></script> | |||
| <script type="application/javascript" tal:content="structure view/fbjs"></script> | |||
There was a problem hiding this comment.
Use structure to produce the &
|
|
||
| self.document.setLanguage('en') | ||
| view = document.restrictedTraverse(plugin_view) | ||
| html = view.metadata() | ||
| self.assertIn('connect.facebook.net/en_GB/all.js', html) | ||
| self.assertIn('connect.facebook.net/en_GB/sdk.js', html) |
There was a problem hiding this comment.
Isn't it supposed to be en_US here? I think we have a Bug.
There was a problem hiding this comment.
I have no idea; you have to dig further on it.
There was a problem hiding this comment.
The code that produces the language is not a simple one. I'll use this issue to check it out #122
rodfersou
changed the title
CHANGES.rst
Outdated
| @@ -6,6 +6,9 @@ There's a frood who really knows where his towel is. | |||
| 2.10.1 (unreleased) | |||
| ^^^^^^^^^^^^^^^^^^^ | |||
|
|
|||
| - Update plugins javascript (closes `#117 <https://github.com/collective/sc.social.like/issues/117>`_). | |||
There was a problem hiding this comment.
this is not closing the issue; the issue serves only as a reference; the changelog entry must be something like: Facebook's widget code was updated… blah, blah, blah.
we'll take care of that later.
rodfersou
force-pushed
the
issue_117
branch
2 times, most recently
from
ee60716 to
4634ba5
Compare
WIP
Documentation: https://developers.facebook.com/docs/plugins/share-button
Todo list:
Do not trackoption activated.- The answer is
Yes. It is a bad behavior for mobile to open a new tab. Of course they prefer if you use the native share option from mobile, but what if you didn't install the facebook app in your phone? you just can't share the page, and this option fix the behavior to don't jump to the new tab.