These typos do not belong to code, do they? #3470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skangas
reviewed
Jun 23, 2024
DimitriPapadopoulos
force-pushed
the
code
branch
2 times, most recently
from
34fadb5 to
8f5c0a6
Compare
peternewman
reviewed
Jun 23, 2024
DimitriPapadopoulos
force-pushed
the
code
branch
from
8f5c0a6 to
e06e729
Compare
|
I have left a handful changes. |
skangas
reviewed
Jun 23, 2024
skangas
approved these changes
Jun 23, 2024
DimitriPapadopoulos
force-pushed
the
code
branch
from
e06e729 to
1558b77
Compare
While the suggested fixes are words often used in code, the typos themselves do not seem to be valid words - even in code.
DimitriPapadopoulos
force-pushed
the
code
branch
from
1558b77 to
df4c1d2
Compare
TheGiraffe3
approved these changes
Nov 23, 2024
|
some of these are misspellings of commonly used coding terminology. |
Yes, hence why they've been moved to the main dictionary @luzpaz . The code dictionary is only for where the typo is valid in code but a typo in normal usage. So technically it's the !code dictionary! |
peternewman
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the suggested fixes are words often used in code, the typos themselves do not seem to be valid words - even in code.
Fixes #3430 (comment).