-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Clean up bundle caching feature flag #3659
base: main
Are you sure you want to change the base?
chore: Clean up bundle caching feature flag #3659
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3659 +/- ##
==========================================
+ Coverage 98.93% 98.94% +0.01%
==========================================
Files 815 815
Lines 14686 14680 -6
Branches 4160 4156 -4
==========================================
- Hits 14529 14525 -4
+ Misses 150 148 -2
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3659 +/- ##
==========================================
+ Coverage 98.93% 98.94% +0.01%
==========================================
Files 815 815
Lines 14686 14680 -6
Branches 4168 4156 -12
==========================================
- Hits 14529 14525 -4
+ Misses 150 148 -2
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will decrease total bundle size by 302 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3659 +/- ##
==========================================
+ Coverage 98.93% 98.94% +0.01%
==========================================
Files 815 815
Lines 14686 14680 -6
Branches 4168 4156 -12
==========================================
- Hits 14529 14525 -4
+ Misses 150 148 -2
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3659 +/- ##
==========================================
+ Coverage 98.93% 98.94% +0.01%
==========================================
Files 815 815
Lines 14686 14680 -6
Branches 4160 4164 +4
==========================================
- Hits 14529 14525 -4
+ Misses 150 148 -2
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Description
This PR just removes the
displayBundleCachingModal
from the codebase cleaning up things once everything has been fully released.Closes codecov/engineering-team#3157
Notable Changes
BundleSelection
andConfigurationManager