Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Clean up bundle caching feature flag #3659

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nicholas-codecov
Copy link
Contributor

Description

This PR just removes the displayBundleCachingModal from the codebase cleaning up things once everything has been fully released.

Closes codecov/engineering-team#3157

Notable Changes

  • Clean up feature flag in BundleSelection and ConfigurationManager

@codecov-notifications
Copy link

codecov-notifications bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3659      +/-   ##
==========================================
+ Coverage   98.93%   98.94%   +0.01%     
==========================================
  Files         815      815              
  Lines       14686    14680       -6     
  Branches     4160     4156       -4     
==========================================
- Hits        14529    14525       -4     
+ Misses        150      148       -2     
  Partials        7        7              
Files with missing lines Coverage Δ
.../BundleContent/BundleSelection/BundleSelection.tsx 100.00% <100.00%> (+5.88%) ⬆️
...tabs/ConfigurationManager/ConfigurationManager.tsx 100.00% <100.00%> (+3.12%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.65% <100.00%> (+0.02%) ⬆️
Services 99.34% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a916ed4...26beebf. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.94%. Comparing base (a916ed4) to head (26beebf).

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3659      +/-   ##
==========================================
+ Coverage   98.93%   98.94%   +0.01%     
==========================================
  Files         815      815              
  Lines       14686    14680       -6     
  Branches     4168     4156      -12     
==========================================
- Hits        14529    14525       -4     
+ Misses        150      148       -2     
  Partials        7        7              
Files with missing lines Coverage Δ
.../BundleContent/BundleSelection/BundleSelection.tsx 100.00% <100.00%> (+5.88%) ⬆️
...tabs/ConfigurationManager/ConfigurationManager.tsx 100.00% <100.00%> (+3.12%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.65% <100.00%> (+0.02%) ⬆️
Services 99.34% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a916ed4...26beebf. Read the comment docs.

Copy link

codecov bot commented Jan 15, 2025

Bundle Report

Changes will decrease total bundle size by 302 bytes (-0.0%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.05MB 150 bytes (-0.0%) ⬇️
gazebo-production-esm 6.1MB 152 bytes (-0.0%) ⬇️

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.94%. Comparing base (a916ed4) to head (26beebf).

✅ All tests successful. No failed tests found.

@@            Coverage Diff             @@
##             main    #3659      +/-   ##
==========================================
+ Coverage   98.93%   98.94%   +0.01%     
==========================================
  Files         815      815              
  Lines       14686    14680       -6     
  Branches     4168     4156      -12     
==========================================
- Hits        14529    14525       -4     
+ Misses        150      148       -2     
  Partials        7        7              
Files with missing lines Coverage Δ
.../BundleContent/BundleSelection/BundleSelection.tsx 100.00% <100.00%> (+5.88%) ⬆️
...tabs/ConfigurationManager/ConfigurationManager.tsx 100.00% <100.00%> (+3.12%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.65% <100.00%> (+0.02%) ⬆️
Services 99.34% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a916ed4...26beebf. Read the comment docs.

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.94%. Comparing base (a916ed4) to head (26beebf).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3659      +/-   ##
==========================================
+ Coverage   98.93%   98.94%   +0.01%     
==========================================
  Files         815      815              
  Lines       14686    14680       -6     
  Branches     4160     4164       +4     
==========================================
- Hits        14529    14525       -4     
+ Misses        150      148       -2     
  Partials        7        7              
Files with missing lines Coverage Δ
.../BundleContent/BundleSelection/BundleSelection.tsx 100.00% <100.00%> (+5.88%) ⬆️
...tabs/ConfigurationManager/ConfigurationManager.tsx 100.00% <100.00%> (+3.12%) ⬆️
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.71% <ø> (ø)
Pages 98.65% <100.00%> (+0.02%) ⬆️
Services 99.34% <ø> (ø)
Shared 99.37% <ø> (ø)
UI 99.14% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a916ed4...26beebf. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
26beebf Wed, 15 Jan 2025 12:58:37 GMT Cloud Enterprise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] Apply Modal to Bundles and Configuration Tabs
3 participants