Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cy/new tos #3642

Open
wants to merge 5 commits into
base: cy/non_pat_appless
Choose a base branch
from
Open

Cy/new tos #3642

wants to merge 5 commits into from

Conversation

calvin-codecov
Copy link
Contributor

@calvin-codecov calvin-codecov commented Jan 8, 2025

Description

Closes codecov/engineering-team#2828

Figma: https://www.figma.com/design/SsoxtY2SB73l0wiLbJ8FhZ/GH-2092?node-id=2288-16704&t=UJWDkZD99C5y1myx-1

Associated API PR: codecov/codecov-api#1094

Notable Changes

  • Modified the TOS screen to ask for both email and name as required fields
  • Removed some customerIntent instances as we no longer ask users

Screenshots

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (cy/non_pat_appless@fb2c147). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/pages/TermsOfService/TermsOfService.tsx 93.75% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             cy/non_pat_appless    #3642   +/-   ##
=====================================================
  Coverage                      ?   98.93%           
=====================================================
  Files                         ?      814           
  Lines                         ?    14623           
  Branches                      ?     4157           
=====================================================
  Hits                          ?    14467           
  Misses                        ?      149           
  Partials                      ?        7           
Files with missing lines Coverage Δ
...rc/pages/TermsOfService/hooks/useTermsOfService.ts 100.00% <100.00%> (ø)
src/pages/TermsOfService/TermsOfService.tsx 97.87% <93.75%> (ø)
Components Coverage Δ
Assets 100.00% <0.00%> (?)
Layouts 99.71% <0.00%> (?)
Pages 98.63% <0.00%> (?)
Services 99.34% <0.00%> (?)
Shared 99.37% <0.00%> (?)
UI 99.14% <0.00%> (?)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb2c147...e2ca166. Read the comment docs.

@codecov-staging
Copy link

codecov-staging bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/pages/TermsOfService/TermsOfService.tsx 93.75% 1 Missing ⚠️
@@                  Coverage Diff                  @@
##             cy/non_pat_appless    #3642   +/-   ##
=====================================================
  Coverage                      ?   98.93%           
=====================================================
  Files                         ?      814           
  Lines                         ?    14623           
  Branches                      ?     4157           
=====================================================
  Hits                          ?    14467           
  Misses                        ?      149           
  Partials                      ?        7           
Files with missing lines Coverage Δ
...rc/pages/TermsOfService/hooks/useTermsOfService.ts 100.00% <100.00%> (ø)
src/pages/TermsOfService/TermsOfService.tsx 97.87% <93.75%> (ø)
Components Coverage Δ
Assets 100.00% <0.00%> (?)
Layouts 99.71% <0.00%> (?)
Pages 98.63% <0.00%> (?)
Services 99.34% <0.00%> (?)
Shared 99.37% <0.00%> (?)
UI 99.14% <0.00%> (?)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb2c147...e2ca166. Read the comment docs.

Copy link

codecov-public-qa bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (cy/non_pat_appless@fb2c147). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/pages/TermsOfService/TermsOfService.tsx 93.75% 1 Missing ⚠️
@@                  Coverage Diff                  @@
##             cy/non_pat_appless    #3642   +/-   ##
=====================================================
  Coverage                      ?   98.93%           
=====================================================
  Files                         ?      814           
  Lines                         ?    14623           
  Branches                      ?     4157           
=====================================================
  Hits                          ?    14467           
  Misses                        ?      149           
  Partials                      ?        7           
Files with missing lines Coverage Δ
...rc/pages/TermsOfService/hooks/useTermsOfService.ts 100.00% <100.00%> (ø)
src/pages/TermsOfService/TermsOfService.tsx 97.87% <93.75%> (ø)
Components Coverage Δ
Assets 100.00% <0.00%> (?)
Layouts 99.71% <0.00%> (?)
Pages 98.63% <0.00%> (?)
Services 99.34% <0.00%> (?)
Shared 99.37% <0.00%> (?)
UI 99.14% <0.00%> (?)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb2c147...e2ca166. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (cy/non_pat_appless@fb2c147). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/pages/TermsOfService/TermsOfService.tsx 93.75% 1 Missing ⚠️
@@                  Coverage Diff                  @@
##             cy/non_pat_appless    #3642   +/-   ##
=====================================================
  Coverage                      ?   98.93%           
=====================================================
  Files                         ?      814           
  Lines                         ?    14623           
  Branches                      ?     4150           
=====================================================
  Hits                          ?    14467           
  Misses                        ?      149           
  Partials                      ?        7           
Files with missing lines Coverage Δ
...rc/pages/TermsOfService/hooks/useTermsOfService.ts 100.00% <100.00%> (ø)
src/pages/TermsOfService/TermsOfService.tsx 97.87% <93.75%> (ø)
Components Coverage Δ
Assets 100.00% <0.00%> (?)
Layouts 99.71% <0.00%> (?)
Pages 98.63% <0.00%> (?)
Services 99.34% <0.00%> (?)
Shared 99.37% <0.00%> (?)
UI 99.14% <0.00%> (?)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb2c147...e2ca166. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Jan 14, 2025

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
f38b6da Tue, 14 Jan 2025 23:05:15 GMT Expired Expired
e2ca166 Wed, 15 Jan 2025 19:01:57 GMT Cloud Enterprise

Copy link
Contributor

@nicholas-codecov nicholas-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple things to peek at 👀

<div className="flex gap-2">
<input
{...register('tos', { required: true })}
{...register('tos')}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Urrm, shouldn't this field still be required, if they don't agree the TOS they shouldn't be able to continue and use the app?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so i was looking into this and the FormSchema above is already enforcing the validation so it wasn't necessary to have required here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to add this in for accessibility purposes as the fields themselves do not indicate that they are required, only once the form is submitted does the error pop up.

@@ -233,7 +234,6 @@ export default function TermsOfService() {
privacy policy
</A>
</span>{' '}
<small className="text-xs">required</small>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, from the designs it seems like this copy is still present 👀

Screenshot 2025-01-15 at 09 01 27

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm this should have been updated in the figma... I'm seeing this
Screenshot 2025-01-15 at 8 36 39 AM
Are you still seeing the version you pasted?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that required may only just be a marker to ensure that the field is required

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is how the existing design looks. Now that we have 3 fields instead of just 1 that is required, we switched to pointing out which of the 4 fields will be optional instead of showing 3 of them are required.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh okok tyty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants