-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cy/new tos #3642
base: cy/non_pat_appless
Are you sure you want to change the base?
Cy/new tos #3642
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## cy/non_pat_appless #3642 +/- ##
=====================================================
Coverage ? 98.93%
=====================================================
Files ? 814
Lines ? 14623
Branches ? 4157
=====================================================
Hits ? 14467
Misses ? 149
Partials ? 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## cy/non_pat_appless #3642 +/- ##
=====================================================
Coverage ? 98.93%
=====================================================
Files ? 814
Lines ? 14623
Branches ? 4157
=====================================================
Hits ? 14467
Misses ? 149
Partials ? 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## cy/non_pat_appless #3642 +/- ##
=====================================================
Coverage ? 98.93%
=====================================================
Files ? 814
Lines ? 14623
Branches ? 4157
=====================================================
Hits ? 14467
Misses ? 149
Partials ? 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## cy/non_pat_appless #3642 +/- ##
=====================================================
Coverage ? 98.93%
=====================================================
Files ? 814
Lines ? 14623
Branches ? 4150
=====================================================
Hits ? 14467
Misses ? 149
Partials ? 7
Continue to review full report in Codecov by Sentry.
|
687f749
to
f38b6da
Compare
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple things to peek at 👀
<div className="flex gap-2"> | ||
<input | ||
{...register('tos', { required: true })} | ||
{...register('tos')} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Urrm, shouldn't this field still be required, if they don't agree the TOS they shouldn't be able to continue and use the app?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so i was looking into this and the FormSchema above is already enforcing the validation so it wasn't necessary to have required here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to add this in for accessibility purposes as the fields themselves do not indicate that they are required, only once the form is submitted does the error pop up.
@@ -233,7 +234,6 @@ export default function TermsOfService() { | |||
privacy policy | |||
</A> | |||
</span>{' '} | |||
<small className="text-xs">required</small> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that required
may only just be a marker to ensure that the field is required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is how the existing design looks. Now that we have 3 fields instead of just 1 that is required, we switched to pointing out which of the 4 fields will be optional instead of showing 3 of them are required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ahhh okok tyty!
Description
Closes codecov/engineering-team#2828
Figma: https://www.figma.com/design/SsoxtY2SB73l0wiLbJ8FhZ/GH-2092?node-id=2288-16704&t=UJWDkZD99C5y1myx-1
Associated API PR: codecov/codecov-api#1094
Notable Changes
Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.