add DJANGO_MAILBOX_MESSAGE_UPLOAD_TO to settings, change utils.get_at… #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tachment_save_path to utils.get_save_path, change eml upload_to in model
|
We can not accept PR which does not pass tests. Could you fix that? |
fix get_save_path in Migration
|
fix some things, but now tests failed without traceback after detecting Migrations |
|
Master is green ( https://travis-ci.org/coddingtonbear/django-mailbox/builds/642819853?utm_medium=notification&utm_source=github_status ), so therefore the problem is introduced in the pull request. There are no generated migrations associated with changes in the model. Execute: |
|
fix error in the pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default original message eml store in 'messages/' if DJANGO_MAILBOX_STORE_ORIGINAL_MESSAGE == True
But there are no path settings for eml like for attachment.
Add DJANGO_MAILBOX_MESSAGE_UPLOAD_TO setting, rewrite get_attachment_save_path > get_save_path in utils.py, edit upload_to in model for Message.eml and MessageAttachment.document