sstable: expand sstable iterator block stats #4262
Open
+146
−185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Added iterator stats for rangekey, rangedel, and value blocks. Replaced block.NoReadEnv in NewRawRangeDelIter, NewRawRangeKeyIterm and ReadValueBlockExternal with an instantiated block.ReadEnv with Stats and IterStats fields. Refactored NewPointIter to accept a block.ReadEnv instead of InternalIteratorStats and IterStatsAccumulator. Removed ChildIterStatsAccumulator from category_stats.go as mutex contention in iterator stat reporting has been empirically tested to represent ~0% of overall mutex time in the worst case scenario. Updated interfaces and function calls to reflect changes.
EdwardX29
force-pushed
the
edwardx29/expand-iterator-stats-blockenv
branch
from
ebcb6e0 to
9f49b3d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added iterator stats for rangekey, rangedel, and value blocks. Replaced block.NoReadEnv in NewRawRangeDelIter, NewRawRangeKeyIterm and ReadValueBlockExternal with an instantiated block.ReadEnv with Stats and IterStats fields. Refactored NewPointIter to accept a block.ReadEnv instead of InternalIteratorStats and IterStatsAccumulator. Removed ChildIterStatsAccumulator from category_stats.go as mutex contention in iterator stat reporting has been empirically tested to represent ~0% of overall mutex time in the worst case scenario. Updated interfaces and function calls to reflect changes.