Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add tags to aws_appautoscaling_target #133

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

MaxymVlasov
Copy link
Contributor

what

Update terraform-aws-dynamodb-autoscaler module to set tags for aws_appautoscaling_target resources

references

Related PR: cloudposse/terraform-aws-dynamodb-autoscaler#65

Update `terraform-aws-dynamodb-autoscaler` module to set tags for `aws_appautoscaling_target` resources

Related PR: 
cloudposse/terraform-aws-dynamodb-autoscaler#65
@MaxymVlasov MaxymVlasov requested review from a team as code owners August 6, 2024 14:51
@mergify mergify bot added the triage Needs triage label Aug 6, 2024
@aknysh aknysh added minor New features that do not break anything and removed triage Needs triage labels Aug 6, 2024
@aknysh
Copy link
Member

aknysh commented Aug 6, 2024

/terratest

@MaxymVlasov MaxymVlasov marked this pull request as draft August 6, 2024 15:21
@MaxymVlasov
Copy link
Contributor Author

I change it to draft, as I found that there some extra tags missed - cloudposse/terraform-aws-dynamodb-autoscaler#66

When it will be merged - I'll update this PR to new tag and make it ready once again

@MaxymVlasov MaxymVlasov marked this pull request as ready for review August 6, 2024 16:15
@aknysh
Copy link
Member

aknysh commented Aug 6, 2024

/terratest

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @MaxymVlasov

@aknysh aknysh merged commit 2ee61b0 into cloudposse:main Aug 6, 2024
14 of 15 checks passed
Copy link

github-actions bot commented Aug 6, 2024

These changes were released in v0.37.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor New features that do not break anything
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants