Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul stale keys for labels and code reduction #235

Closed
wants to merge 87 commits into from
Closed

Overhaul stale keys for labels and code reduction #235

wants to merge 87 commits into from

Conversation

rcgottlieb
Copy link
Contributor

@rcgottlieb rcgottlieb commented May 13, 2024 •
edited
Loading

Changes proposed in this pull request:

  • This is the first step in the overhaul of stale keys, which is to use a python client library to talk directly to the pushgateway
  • Many of the changes are around removing the manual process using the requests python library
  • The ORM was changed out to a more manageable SQLAlchemy library with Alembic
  • The other changes are to bring in two new labels warn date and violation date as well as code cleanup

security considerations

Better security as there will be less code

rcgottlieb and others added 30 commits March 8, 2024 17:38
@rcgottlieb
beginning stages of cleanup
fd32c76
@rcgottlieb
major updates and fixes
9b6c974
@rcgottlieb
fixed typo
4c19185
@rcgottlieb
debug
b4af3f3
@rcgottlieb
refactored some code
81460aa
@rcgottlieb
fixed missing comma
5f96ffc
@rcgottlieb
adding missing commas
766744b
@rcgottlieb
added comments and updated logic
e3d3aa2
@rcgottlieb
adding debug
348ff6d
@rcgottlieb
more debug
b6d958a
@rcgottlieb
debug and small fixes
ecfd947
@rcgottlieb
got rid of some debug prints and modified output a bit
03e1fac
@rcgottlieb
debug print
39ac5fd
@rcgottlieb
updated alert verbiage again
c45a5e6
@rcgottlieb
testing some update to logic
04f0c9a
@rcgottlieb
removing some debug code and cleaning up other code
1783f7a
@bengerman13
prefer pathlib over os.path.join
984060d
@bengerman13
Refactoring find_stale_keys
18a5e25 
- move threshold to Dataclass
- use context manager for open
- use constants for warnings
- whitespace tidying
@rcgottlieb
updated more Threshold references
4ae7d38
@rcgottlieb
more cleanup: environs in place of os.getenv
707ec65
@rcgottlieb
Merge pull request #224 from cloud-gov/bb/pairing-refactor
3635dcf 
Bb/pairing refactor
@rcgottlieb
Code cleanup:
c92cc98 
Created a new dataclass to unify user type data
Changed var names to better reflect context
Removed migration code
Other misc
@rcgottlieb
more code cleanup
bde14c2
@rcgottlieb
fixed typo
5efa268
@rcgottlieb
adding runtime for python version
f8db5cf
@rcgottlieb
this time change Python version
040ff80
@rcgottlieb
correct format this time
ee6be8d
@rcgottlieb
using pipenv to install it hopefully
f0476d5
@rcgottlieb
removing the runtime.txt, installing python 3.11 latest
9907ccc
@rcgottlieb
need to install pyenv first
d967e56
rcgottlieb added 24 commits May 2, 2024 17:52
@rcgottlieb
forgot to comment out new code
7fac340
@rcgottlieb
fixed formatting
feb227d
@rcgottlieb
cleaning up some code, removing modules, std on Env
2d20d65
@rcgottlieb
removed some debug print stuff
a1f6ab5
@rcgottlieb
changing debug to print res body
c12ea37
@rcgottlieb
added back time module
58a659f
@rcgottlieb
changing branch to overhaul for debugging
a9203fa
@rcgottlieb
mods to gateway request and debug output
06d2285
@rcgottlieb
swapping back to main branch for prod
06b7ea7
@rcgottlieb
swapping back to main branch for prod
98f761d
@rcgottlieb
fixing typo in pipeline
3c88f89
@rcgottlieb
setting pipeline for debug again, for stale keys
7e848e0
@rcgottlieb
changing output to match prod
810b65f
@rcgottlieb
commented out test code
a38b430
@rcgottlieb
moving to one alert per push
f1783d7
@rcgottlieb
added back missing var
8a804d4
@rcgottlieb
added in a debug print
e07b045
@rcgottlieb
added missing split
047cdcc
@rcgottlieb
added newline back from split
197e5a2
@rcgottlieb
matching request format from prod version
533b7a9
@rcgottlieb
using the pushgateway client now
eb1a75f
@rcgottlieb
adding in the python client lib for Prometheus
574f6f3
@rcgottlieb
mising port added back
63e2886
@rcgottlieb
code cleanup
34792b9
@rcgottlieb rcgottlieb requested a review from a team May 13, 2024 21:32
@rcgottlieb rcgottlieb changed the title Overhaul Overhaul stale keys for labels and code reduction May 13, 2024
@rcgottlieb
Copy link
Contributor Author

closing this in favor of removing the database and creating a new PR

@rcgottlieb rcgottlieb closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rcgottlieb @bengerman13