Skip to content

Commit

Permalink
refactor code for removing unneeded properties etc
Browse files Browse the repository at this point in the history
  • Loading branch information
rcgottlieb committed Jul 2, 2024
1 parent c63e224 commit c9afbb6
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 5 deletions.
1 change: 1 addition & 0 deletions ci/aws-iam-check-keys/find_stale_keys.py
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ def search_for_keys(region_name: str, profile: dict, all_users: list[Threshold])
# into a dictionary to use for the credentials check
csv_reader = csv.DictReader(content_lines, delimiter=",")
not_found = []
row: dict
for row in csv_reader:
user_name = row['user']

Expand Down
1 change: 0 additions & 1 deletion ci/aws-iam-check-keys/threshold.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
@dataclass
class Threshold:
account_type: str
is_wildcard: bool
warn: int
violation: int
alert: bool
Expand Down
4 changes: 0 additions & 4 deletions ci/aws-iam-check-keys/thresholds.yml
Original file line number Diff line number Diff line change
@@ -1,20 +1,16 @@
- account_type: "Operator"
is_wildcard: False
warn: 75
violation: 90
alert: True
- account_type: "Platform"
is_wildcard: False
warn: 80
violation: 165
alert: True
- account_type: "Application"
is_wildcard: False
warn: 80
violation: 165
alert: True
- account_type: "Customer"
is_wildcard: True
warn: 0
violation: 0
alert: False

0 comments on commit c9afbb6

Please sign in to comment.