Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AzerothCore support #4

Draft
wants to merge 49 commits into
base: TrinityCore
Choose a base branch
from
Draft

AzerothCore support #4

wants to merge 49 commits into from

Conversation

chocochaos
Copy link
Owner

No description provided.

@chocochaos chocochaos changed the title Azeroth core support AzerothCore support Feb 24, 2024
@chocochaos
Copy link
Owner Author

Note to self: [email protected]:wowgaming/3.3.5-interface-files.git

chocochaos added 19 commits March 6, 2024 10:12
@chocochaos
Refactoring progress, mostly focussed on Spy
c0826be
@chocochaos
Test commit
12c821c
@chocochaos
Nil values cannot be concatenated. Revert back to empty strings for now
d533382
@chocochaos
Load LUA files in the correct order
31e5e5f
@chocochaos
Fix incorrect variable reference
a9b32a9
@chocochaos
Prevent error about message being nil
53f2a98
@chocochaos
Attempt to fix nil errors
36fe18c
@chocochaos
Fix some references and add more debugging information
bd07df6
@chocochaos
Use correct concatenation syntax
85d1234
@chocochaos
Resolve incorrect function references
686b2a1
@chocochaos
Add more debug information
7583b65
@chocochaos
Add more debug information
73f01c0
@chocochaos
Add more debug information
9f491e2
@chocochaos
Use explicit identifiers for command handlers
df96077
@chocochaos
Fix playerinfo message detection
8808695
@chocochaos
Add more debug information
2e9168e
@chocochaos
Correctly detect the broken bar character
fc1c13a
@chocochaos
Correctly parse location information
2731cbd
@chocochaos
Remove some debug code, and add better way to handle debug messages
fc32694
chocochaos added 21 commits March 6, 2024 13:00
@chocochaos
Remove forgotten debug message
986d4f7
@chocochaos
Make sure spy window is shown
8aa3c77
@chocochaos
Correctly filter out unknown locations
97f23e0
@chocochaos
FFS: why does azerothcore add spaces around locations?
032f989
@chocochaos
Add code completion hints and use consistent command identifiers for …
e5b1ce7 
…the hud
@chocochaos
More major refactoring, mostly focussed on the command / chat respons…
c9519dc 
…e logic.
@chocochaos
Apparently these includes in XMLs do not work in 3.3.5 - or I messed …
0b97376 
…up. Back to messy toc files then
@chocochaos
Fix a typo
1127413
@chocochaos
Correctly set values in Spy UI
27ce18b
@chocochaos
Quick hacky fix to get the spy window to display before loading data
0bc0523
@chocochaos
Even uglier fix to prevent null index errors
64a37e0
@chocochaos
Fix uninitialised table
c21526f
@chocochaos
Fix infowindow reference
25bdccc
@chocochaos
Add some strategic debug information
666f01a
@chocochaos
Slightly optimise onSuccess flow for readers
53721ad
@chocochaos
Slightly optimise onError flow for readers
024b8d0
@chocochaos
Possibly fix the HUD again (or will it fail to show now as well? ;) )
8c2052a
@chocochaos
Fix incorrect reference
5e3a943
@chocochaos
Fix incorrect reference
312f567
@chocochaos
More robust handling of GM mode in playerinfo reader
95160d7
@chocochaos
Fix state being used after it has been reset
050ad4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chocochaos @FeedehC @55Honey @Kebful @Kitzunu