Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water bridge from iterable of mols #237

Open
wants to merge 2 commits into
base: water_bridge
Choose a base branch
from

Conversation

cbouy
Copy link
Member

@cbouy cbouy commented Dec 29, 2024

Generalizes to any input (trajectory is already done, this introduces the missing support for Iterable[Molecule])

Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 6 lines in your changes missing coverage. Please review.

Project coverage is 94.46%. Comparing base (711e037) to head (4a87e2e).

Files with missing lines Patch % Lines
prolif/interactions/water_bridge.py 81.25% 3 Missing ⚠️
prolif/typeshed.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           water_bridge     #237      +/-   ##
================================================
- Coverage         94.72%   94.46%   -0.26%     
================================================
  Files                22       23       +1     
  Lines              1650     1681      +31     
================================================
+ Hits               1563     1588      +25     
- Misses               87       93       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbouy cbouy force-pushed the water_bridge_from_mols branch from f94e49c to 4a87e2e Compare December 29, 2024 15:51
@cbouy cbouy requested a review from talagayev December 29, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant