Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle mixed types in ResidueId comparison #235

Merged
merged 4 commits into from
Dec 23, 2024

Conversation

amorehead
Copy link
Contributor

  • Handles mixed types (e.g., str and None) in ResidueId comparisons

@cbouy cbouy self-assigned this Dec 23, 2024
@cbouy
Copy link
Member

cbouy commented Dec 23, 2024

Thanks for the contribution @amorehead, I'll just add some tests to your PR

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.44%. Comparing base (597083d) to head (8cfa394).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #235   +/-   ##
=======================================
  Coverage   94.44%   94.44%           
=======================================
  Files          21       21           
  Lines        1511     1513    +2     
=======================================
+ Hits         1427     1429    +2     
  Misses         84       84           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cbouy cbouy merged commit 742203b into chemosim-lab:master Dec 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants