Track cardinality of querysel seal. #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow to differentiate between sealed queryset that would benefit from prefetching many-to-many relationships and the ones that don't. In other words, warning about N+1 query issues when fetching a many-to-many relationship from a singular result (.get(), .first()) is arguably bad practice as it could be beneficial to defer the fetching. This is a common scenario when seal()'ing a queryset meant to be used both by singular (detail view) and multiple results (list view) code paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to differentiate between sealed queryset that would benefit from prefetching many-to-many relationships and the ones that don't.
In other words, warning about N+1 query issues when fetching a many-to-many relationship from a singular result (.get(), .first()) is arguably bad practice as it could be beneficial to defer the fetching. This is a common scenario when seal()'ing a queryset meant to be used both by singular (detail view) and multiple results (list view) code paths.
This paves the way for addressing #44 but it will likely need to be opt-in through a setting to maintain backward compatibility.