Merge pull request #57 from chanzuckerberg/jgadling/fix-viz-tests

Fix field visibility tests.

platformics/codegen/templates/api/types/class_name.py.j2

@@ -18,7 +18,12 @@ import database.models as db
 import strawberry
 import datetime
 from platformics.api.core.query_builder import get_db_rows, get_aggregate_db_rows
-from api.validators.{{cls.snake_name}} import {{cls.name}}CreateInputValidator, {{cls.name}}UpdateInputValidator
+{%- if cls.create_fields %}
+from api.validators.{{cls.snake_name}} import {{cls.name}}CreateInputValidator
+{%- endif %}
+{%- if cls.mutable_fields %}
+from api.validators.{{cls.snake_name}} import {{cls.name}}UpdateInputValidator
+{%- endif %}
 {%- if render_files %}
 from platformics.api.files import File, FileWhereClause
 {%- endif %}

test_app/schema/schema.yaml

@@ -62,6 +62,7 @@ classes:
       producing_run_id:
         range: uuid
         annotations:
+          mutable: false  # This field can't be modified by an `Update` mutation
           system_writable_only: True
       owner_user_id:
         range: integer
@@ -220,6 +221,7 @@ classes:
     attributes:
       file:
         range: File
+        readonly: true
         annotations:
           cascade_delete: true
       sequencing_reads:
@@ -340,4 +342,5 @@ classes:
         range: string
         required: true
     annotations:
+      mutable: false
       plural: ImmutableTypes

test_app/tests/test_field_visibility.py

@@ -130,7 +130,7 @@ async def test_update_fields(
     ]
     fields = [field["name"] for field in create_type["inputFields"]]
     # We have a limited subset of mutable fields on SequencingRead
-    assert set(fields) == set(["nucleicAcid", "clearlabsExport", "technology", "sampleId", "deletedAt"])
+    assert set(fields) == set(["nucleicAcid", "sampleId", "technology", "protocol", "deletedAt", "primerFileId", "collectionId"])
 
 
 # Make sure we only allow certain fields to be set at entity creation time.