sql output: handle empty string fields paramter

Treat an empty string `fields` parameter as unset parameter, fixing a crash in default configuration fixes #2548
certtools · Jan 8, 2025 · 5b6c602 · 5b6c602
1 parent 98df0cd
commit 5b6c602
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -40,6 +40,8 @@
   - The requirement can only be installed on Python version < 3.12.
   - Add a check on the Python version and exit if incompatible.
   - Add a deprecation warning (PR#2544 by Sebastian Wagner)
+- `intelmq.bots.outputs.sql.output`:
+  - Treat an empty string `fields` parameter as unset parameter, fixing a crash in default configuration (PR#2548 by Sebastian Wagner, fixes #2548).
 
 ### Documentation
 

diff --git a/intelmq/bots/outputs/sql/output.py b/intelmq/bots/outputs/sql/output.py
@@ -43,9 +43,7 @@ def init(self):
     def process(self):
         event = self.receive_message().to_dict(jsondict_as_string=self.jsondict_as_string)
 
-        key_names = self.fields
-        if key_names is None:
-            key_names = event.keys()
+        key_names = self.fields or event.keys()
         valid_keys = [key for key in key_names if key in event]
         keys = '", "'.join(valid_keys)
         values = self.prepare_values(itemgetter_tuple(*valid_keys)(event))