-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Add hint that the userID must not include the client.
prefix
#5072
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please make similar comment in https://github.com/ceph/ceph-csi/blob/devel/examples/cephfs/secret.yaml and https://github.com/ceph/ceph-csi/blob/devel/examples/rbd/secret.yaml and drop other commit related to controller-runtime update
go.mod
Outdated
@@ -42,7 +42,7 @@ require ( | |||
k8s.io/mount-utils v0.31.3 | |||
k8s.io/pod-security-admission v0.31.3 | |||
k8s.io/utils v0.0.0-20240711033017-18e509b52bc8 | |||
sigs.k8s.io/controller-runtime v0.19.3 | |||
sigs.k8s.io/controller-runtime v0.19.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure how this got included, please keep the change to the userKey
only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fork was out of sync :)
c4ad526
to
4e70d98
Compare
done :) |
@Mergifyio rebase |
Signed-off-by: Matthias Linhuber <[email protected]>
✅ Branch has been successfully rebased |
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at bdd7c5a |
/test ci/centos/k8s-e2e-external-storage/1.30 |
/test ci/centos/upgrade-tests-cephfs |
/test ci/centos/mini-e2e-helm/k8s-1.30 |
/test ci/centos/upgrade-tests-rbd |
/test ci/centos/k8s-e2e-external-storage/1.31 |
/test ci/centos/mini-e2e/k8s-1.30 |
/test ci/centos/mini-e2e-helm/k8s-1.31 |
/test ci/centos/mini-e2e/k8s-1.31 |
/test ci/centos/k8s-e2e-external-storage/1.32 |
/test ci/centos/mini-e2e-helm/k8s-1.32 |
/test ci/centos/mini-e2e/k8s-1.32 |
Describe what this PR does
This PR only adds a small hint in the rbd helm values chart. It took me quite some time to find my config error and this hint hopefully safes someone some debug time :)
Problem was that i included the
client.
prefix in theuserID
secret.Related issues
Mention any github issues relevant to this PR. Adding below line
will help to auto close the issue once the PR is merged.
Problem mentioned in: #4304
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>
: retest the<job-name>
after unrelatedfailure (please report the failure too!)