fix: use default send rate configured by celestia-app #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rootulp
requested review from
evan-forbes and
ninabarbakadze
and removed request for
a team
rach-id
approved these changes
Jan 13, 2025
rootulp
added a commit
to celestiaorg/celestia-app
that referenced
this pull request
Jan 14, 2025
Part of #4213 The real fix is in celestiaorg/cosmos-sdk#425 but this is a nice to have.
evan-forbes
approved these changes
Jan 14, 2025
evan-forbes
merged commit fc94c0e
into
celestiaorg:release/v0.46.x-celestia
34 of 35 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes celestiaorg/celestia-app#4213 by allowing celestia-app's default_overrides to be the source of truth.
Testing
In celestia-app I used this version and observed the overrides take effect