Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test-e2e): add first knuu e2e-test #3983

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

smuu
Copy link
Member

@smuu smuu commented Dec 6, 2024

PR is based on and supersedes: #3795

This PR adds the ability to run e2e tests with knuu using and building on top of the testnet abstraction of knuu in celestia-app.
To run the e2e test, you need to make sure to place the kubeconfig in your filesystem and then run make test-e2e.

The main file to review is:
https://github.com/celestiaorg/celestia-node/pull/3983/files#diff-948601d377bb9ccc69a268ea8f1307651c5ad023d0701ec7ecc0f6253c846dca (test/e2e/simple.go)

Please let me know if you have any questions.

@github-actions github-actions bot added the external Issues created by non node team members label Dec 6, 2024
mojtaba-esk
mojtaba-esk previously approved these changes Dec 6, 2024
Copy link

@mojtaba-esk mojtaba-esk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. Thanks!
There are only a few linter complains that I would fix.

test/e2e/prometheus/prometheus.go Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
test/e2e/testnet/helper.go Outdated Show resolved Hide resolved
test/e2e/helper.go Show resolved Hide resolved
test/e2e/prometheus/prometheus.go Outdated Show resolved Hide resolved
test/e2e/prometheus/prometheus.go Outdated Show resolved Hide resolved
test/e2e/prometheus/prometheus.go Outdated Show resolved Hide resolved
test/e2e/testnet/testnet.go Outdated Show resolved Hide resolved
test/e2e/testnet/testnet.go Outdated Show resolved Hide resolved
test/e2e/testnet/testnet.go Show resolved Hide resolved
@cristaloleg cristaloleg added kind:testing Related to unit tests e2e e2e testing related labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e e2e testing related external Issues created by non node team members kind:testing Related to unit tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants