Update Makefile: Fix typo max_txs_bytes #4250
Conversation
Enigma-Validator
requested review from
cmwaters and
rach-id
and removed request for
a team
📝 WalkthroughWalkthroughThe pull request involves a minor correction in the Makefile's Changes
Possibly related PRs
Suggested labels
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Makefile(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Summary
🔇 Additional comments (1)
Makefile (1)
353-353: LGTM! Typo fix looks good.The correction from
max_txs_bytestomax_tx_bytesin the sed pattern ensures that the correct configuration parameter is being modified.
| @@ -350,7 +350,7 @@ configure-v3: | |||
| sed -i "s/^send_rate = .*/send_rate = $(SEND_RECV_RATE)/" $(CONFIG_FILE); \ | |||
| sed -i "s/^ttl-num-blocks = .*/ttl-num-blocks = 12/" $(CONFIG_FILE); \ | |||
| sed -i "s/^ttl-duration = .*/ttl-duration = \"1m15s\"/" $(CONFIG_FILE); \ | |||
| sed -i "s/^max_txs_bytes = .*/max_tx_bytes = 7897088/" $(CONFIG_FILE); \ | |||
| sed -i "s/^max_tx_bytes = .*/max_tx_bytes = 7897088/" $(CONFIG_FILE); \ | |||
| sed -i '' "s/^max_txs_bytes = .*/max_txs_bytes = 39485440/" $(CONFIG_FILE); \ | |||
There was a problem hiding this comment.
Fix incorrect sed syntax for Linux systems.
The Linux section incorrectly uses macOS-style sed syntax (sed -i ''). On Linux, the empty string argument is not needed and can cause errors.
Apply this fix:
- sed -i '' "s/^max_txs_bytes = .*/max_txs_bytes = 39485440/" $(CONFIG_FILE); \
+ sed -i "s/^max_txs_bytes = .*/max_txs_bytes = 39485440/" $(CONFIG_FILE); \📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| sed -i '' "s/^max_txs_bytes = .*/max_txs_bytes = 39485440/" $(CONFIG_FILE); \ | |
| sed -i "s/^max_txs_bytes = .*/max_txs_bytes = 39485440/" $(CONFIG_FILE); \ |
|
This config seems to work. Two changes, one to fix max_tx_bytes and other to remove '' from max_txs_bytes |
evan-forbes
added
the
backport:v3.x
<!-- Please read and fill out this form before submitting your PR. Please make sure you have reviewed our contributors guide before submitting your first PR. --> ## Overview <!-- There was a typo on the sed command sed -i "s/^max_txs_bytes = .*/max_tx_bytes = 7897088/" $(CONFIG_FILE); Instead of sed -i "s/^max_tx_bytes = .*/max_tx_bytes = 7897088/" $(CONFIG_FILE); --> (cherry picked from commit 8093218) # Conflicts: # Makefile
## Overview <hr>This is an automatic backport of pull request #4250 done by [Mergify](https://mergify.com). --------- Co-authored-by: Enigma-Validator <[email protected]> Co-authored-by: Rootul Patel <[email protected]>
Overview